add more types #473
Merged
add more types #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RagnarGrootKoerkamp
force-pushed
the
more-typing
branch
from
b23f3bb to
c805e4d
Compare
RagnarGrootKoerkamp
approved these changes
Oct 29, 2025
Owner
RagnarGrootKoerkamp
left a comment
RagnarGrootKoerkamp
left a comment
There was a problem hiding this comment.
See tiny fixes & suggestion in last commit.
mpsijm
added a commit
that referenced
this pull request
Nov 8, 2025
mpsijm
reviewed
Nov 8, 2025
Comment on lines
+10
to
+12
| # organize imports in two blocks, non local and local | ||
| section-order = ["standard-library", "first-party"] | ||
| default-section = "standard-library" |
Collaborator
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
No opinion here / I am fine with whatever. This was just the setting closest to how we already formatted the includes manually
Collaborator
There was a problem hiding this comment.
All right! Then I'll change the settings to default when #474 no longer blocks this. The diff should not be too big, and it's automated anyway 😄
Contributor
There was a problem hiding this comment.
feel free to just do it, I think I will just write a regex for the rebase anyways
This was referenced Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#102